linux-kernel - Re: [PATCH v11 04/10] PCI: cadence: Add support for High Perf Architecture (HPA) controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52abaad8-a43e-4e29-93d7-86a3245692c3@cixtech.com>
Date: Tue, 18 Nov 2025 08:45:09 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
 fugang.duan@...tech.com, guoyin.chen@...tech.com, peter.chen@...tech.com,
 cix-kernel-upstream@...tech.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 04/10] PCI: cadence: Add support for High Perf
 Architecture (HPA) controller



On 11/18/2025 5:08 AM, Bjorn Helgaas wrote:
> EXTERNAL EMAIL
> 
> On Sat, Nov 08, 2025 at 10:02:59PM +0800, hans.zhang@...tech.com wrote:
>> From: Manikandan K Pillai <mpillai@...ence.com>
>>
>> Add support for Cadence PCIe RP configuration for High Performance
>> Architecture (HPA) controllers. The Cadence High Performance
>> controllers are the latest PCIe controllers that have support for DMA,
>> optional IDE and updated register set. Add register definitions for High
>> Performance Architecture (HPA) PCIe controllers.
> 
>>   /**
>>    * struct cdns_pcie - private data for Cadence PCIe controller drivers
>>    * @reg_base: IO mapped register base
>>    * @mem_res: start/end offsets in the physical system memory to map PCI accesses
>> + * @msg_res: Region for send message to map PCI accesses
>>    * @dev: PCIe controller
>>    * @is_rc: tell whether the PCIe controller mode is Root Complex or Endpoint.
>>    * @phy_count: number of supported PHY devices
>> @@ -45,16 +85,20 @@ struct cdns_pcie_ops {
>>    * @link: list of pointers to corresponding device link representations
>>    * @ops: Platform-specific ops to control various inputs from Cadence PCIe
>>    *       wrapper
>> + * @cdns_pcie_reg_offsets: Register bank offsets for different SoC
>>    */
>>   struct cdns_pcie {
>> -     void __iomem            *reg_base;
>> -     struct resource         *mem_res;
>> -     struct device           *dev;
>> -     bool                    is_rc;
>> -     int                     phy_count;
>> -     struct phy              **phy;
>> -     struct device_link      **link;
>> -     const struct cdns_pcie_ops *ops;
>> +     void __iomem                         *reg_base;
>> +     void __iomem                         *mem_base;
> 
>    $ DIR=drivers/pci/
>    $ find $DIR -type f -name \*.[ch] | xargs scripts/kernel-doc -none 2>&1
>    Warning: drivers/pci/controller/cadence/pcie-cadence.h:101 struct member 'mem_base' not described in 'cdns_pcie'
> 
> Can you supply text for this doc?  We can amend the commit to include
> it.

Hi Bjorn,

This variable should be deleted. Mani, could you please help handle it?

It seems that Manikandan missed deleting this variable during the 
modification process. I checked and found that it wasn't used.


Best regards,
Hans