linux-kernel - Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2b9fb9c-440d-4e41-b4e8-7428fcf9c2ca@suse.de>
Date: Tue, 18 Nov 2025 08:01:10 +0100
From: Hannes Reinecke <hare@...e.de>
To: Justin Tee <justintee8345@...il.com>, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: jsmart2021@...il.com, justin.tee@...adcom.com,
 Daniel Wagner <wagi@...nel.org>
Subject: Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for
 authentication failures

On 11/17/25 19:43, Justin Tee wrote:
> With authentication, in addition to EKEYREJECTED there is also no point in
> retrying reconnects when status is ENOKEY.  Thus, add -ENOKEY as another
> criteria to determine when to stop retries.
> 
> Cc: Daniel Wagner <wagi@...nel.org>
> Cc: Hannes Reinecke <hare@...e.de>
> Closes: https://lore.kernel.org/linux-nvme/20250829-nvme-fc-sync-v3-0-d69c87e63aee@kernel.org/
> Signed-off-by: Justin Tee <justintee8345@...il.com>
> ---
>   drivers/nvme/host/fabrics.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index 3d4d6d8e88c4..fb7765bf0cdf 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -594,7 +594,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl, int status)
>   	if (status > 0 && (status & NVME_STATUS_DNR))
>   		return false;
>   
> -	if (status == -EKEYREJECTED)
> +	if (status == -EKEYREJECTED || status == -ENOKEY)
>   		return false;
>   
>   	if (ctrl->opts->max_reconnects == -1 ||

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich