linux-kernel - Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de42309a-8103-457c-a150-402488b36ede@flourine.local>
Date: Mon, 24 Nov 2025 11:26:08 +0100
From: Daniel Wagner <dwagner@...e.de>
To: Hannes Reinecke <hare@...e.de>
Cc: Justin Tee <justintee8345@...il.com>, linux-nvme@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, jsmart2021@...il.com, justin.tee@...adcom.com, 
	Daniel Wagner <wagi@...nel.org>
Subject: Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for
 authentication failures

Hi Justin,

Sorry for the late response. I was on vacation.

On Tue, Nov 18, 2025 at 08:01:10AM +0100, Hannes Reinecke wrote:
> On 11/17/25 19:43, Justin Tee wrote:
> > With authentication, in addition to EKEYREJECTED there is also no point in
> > retrying reconnects when status is ENOKEY.  Thus, add -ENOKEY as another
> > criteria to determine when to stop retries.
> > 
> > Cc: Daniel Wagner <wagi@...nel.org>
> > Cc: Hannes Reinecke <hare@...e.de>
> > Closes: https://lore.kernel.org/linux-nvme/20250829-nvme-fc-sync-v3-0-d69c87e63aee@kernel.org/
> > Signed-off-by: Justin Tee <justintee8345@...il.com>

The patch itself is okay, nothing against it. But it wont close the bug
report. blktests nvme/041 just passes because we don't check the return
code from 'nvme connect' yet. I wanted to add this for a while, time to
do it.

Furthermore, the test now races with the kernel. If the worker thread in
the kernel is delayed, the 'nvme disconnect' might still see a controller:

     Test authenticated connection
    -disconnected 1 controller(s)
    +disconnected 0 controller(s)

Anyway, I am fine with this change just without the 'Closes' tag.

Tested-by: Daniel Wagner <wagi@...nel.org>
Reviewed-by: Daniel Wagner <wagi@...nel.org>