linux-kernel - Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+=0d2aYn_q=i6Yy=zSu6eE=Fj0oTk4t00e1uezBxqNc5E7pdg@mail.gmail.com>
Date: Tue, 18 Nov 2025 15:26:09 +0800
From: Brian Kao <powenkao@...gle.com>
To: Peter Wang (王信友) <peter.wang@...iatek.com>
Cc: "beanhuo@...ron.com" <beanhuo@...ron.com>, "avri.altman@....com" <avri.altman@....com>, 
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>, 
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "bvanassche@....org" <bvanassche@....org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, 
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>, "mani@...nel.org" <mani@...nel.org>, 
	"James.Bottomley@...senpartnership.com" <James.Bottomley@...senpartnership.com>, 
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error

> Fault injection using saved_uic_err could create this situation,
> but if this cannot happen in reality, we should consider whether
> this is a reasonable test case? If it is, then I think this patch
> looks good to me. If not, maybe we should get the runtime PM state
> in the fault injection and remove this redundant recovery code.
> What do you think?

Hi Peter,

Sorry that I didn't mention that this is in the resume path.
The resume flow in bellow will re-enable IRQ and go through full
re-initialization which potentially trigger issue I described
previously
```
ufshcd_resume()
    ufshcd_enable_irq(hba);
ufshcd_wl_resume()
    ufshcd_reset_and_restore()                            <== depends
on PM level
        ufshcd_hba_enable()
        ufshcd_probe_hba()
    ufshcd_set_dev_pwr_mode(hba, UFS_ACTIVE_PWR_MODE);    <== EH is
scheduled before this point
    ....
```