linux-kernel - Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <301cc0724a9e22bf195cb0bafb0c5d298e93e99d.camel@mediatek.com>
Date: Wed, 19 Nov 2025 09:18:09 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "powenkao@...gle.com" <powenkao@...gle.com>
CC: "beanhuo@...ron.com" <beanhuo@...ron.com>, "avri.altman@....com"
	<avri.altman@....com>, "quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"bvanassche@....org" <bvanassche@....org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "adrian.hunter@...el.com"
	<adrian.hunter@...el.com>, "mani@...nel.org" <mani@...nel.org>,
	"James.Bottomley@...senpartnership.com"
	<James.Bottomley@...senpartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume
 error

On Tue, 2025-11-18 at 15:26 +0800, Brian Kao wrote
> 
> Hi Peter,
> 
> Sorry that I didn't mention that this is in the resume path.
> The resume flow in bellow will re-enable IRQ and go through full
> re-initialization which potentially trigger issue I described
> previously
> ```
> ufshcd_resume()
>     ufshcd_enable_irq(hba);
> ufshcd_wl_resume()
>     ufshcd_reset_and_restore()                            <== depends
> on PM level
>         ufshcd_hba_enable()
>         ufshcd_probe_hba()
>     ufshcd_set_dev_pwr_mode(hba, UFS_ACTIVE_PWR_MODE);    <== EH is
> scheduled before this point
>     ....
> ```

Hi Brian,

You mean that the suspend level sets the link to off, and then
ufshcd_reset_and_restore encounters an error during the resume 
flow, right? This does seem to be a potential issue.

Thanks
Peter