linux-kernel - Re: [PATCH net] team: Move team device type change at the end of team_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6fa0160-aac6-4fc4-b252-7151a0cb91d3@redhat.com>
Date: Tue, 18 Nov 2025 12:46:36 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: "Nikola Z. Ivanov" <zlatistiv@...il.com>, jiri@...nulli.us,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org, david.hunter.linux@...il.com, khalid@...nel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org,
 syzbot+a2a3b519de727b0f7903@...kaller.appspotmail.com
Subject: Re: [PATCH net] team: Move team device type change at the end of
 team_port_add

On 11/12/25 1:34 AM, Nikola Z. Ivanov wrote:
> @@ -1233,6 +1231,10 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
>  		}
>  	}
>  
> +	err = team_dev_type_check_change(dev, port_dev);
> +	if (err)
> +		goto err_set_dev_type;

Please don't add unneeded new labels, instead reuse the exiting
`err_set_slave_promisc`.

Thanks,

Paolo