linux-kernel - Re: [PATCH net] team: Move team device type change at the end of team_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mekjl7qqrb6nkk6ru4fztqxzemldzbsplf5tzuu7amc7yaa5j3@rulh6ijsppaq>
Date: Wed, 19 Nov 2025 17:10:15 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "Nikola Z. Ivanov" <zlatistiv@...il.com>, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org, david.hunter.linux@...il.com, 
	khalid@...nel.org, linux-kernel-mentees@...ts.linuxfoundation.org, 
	syzbot+a2a3b519de727b0f7903@...kaller.appspotmail.com
Subject: Re: [PATCH net] team: Move team device type change at the end of
 team_port_add

Tue, Nov 18, 2025 at 12:46:36PM +0100, pabeni@...hat.com wrote:
>On 11/12/25 1:34 AM, Nikola Z. Ivanov wrote:
>> @@ -1233,6 +1231,10 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
>>  		}
>>  	}
>>  
>> +	err = team_dev_type_check_change(dev, port_dev);
>> +	if (err)
>> +		goto err_set_dev_type;
>
>Please don't add unneeded new labels, instead reuse the exiting
>`err_set_slave_promisc`.

Well, that is how error labels are done in team. "action" and
"err_action" is always paired. Why to break this consistent pattern?