linux-kernel - Re: [PATCH 9/9] ASoC: codecs: lpass-rx-macro: fix mute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2075e642-9976-49a8-a148-3a6fa113e66c@oss.qualcomm.com>
Date: Wed, 19 Nov 2025 15:33:21 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Jonathan Marek <jonathan@...ek.ca>, linux-arm-msm@...r.kernel.org
Cc: Srinivas Kandagatla <srini@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "open list:QCOM AUDIO (ASoC) DRIVERS" <linux-sound@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/9] ASoC: codecs: lpass-rx-macro: fix mute_stream
 affecting all paths



On 11/17/25 5:15 AM, Jonathan Marek wrote:
> The current mute_steam() implementation affects all paths instead of
> only those in use by the DAI.
> 
> For example, playing to 2 DAIs simultaneously with mixing, stopping
> one will mute the other.
> 
> Rework to use the same logic as hw_params() to mute only the relevant paths.
> (also, use "rx->main_clk_users[j] > 0" instead of dsm_reg, which is
> equivalent. I also don't think the clock enable should be in this function,
> but that's a change for another patch)

I agree, we can move the clk to a widget.

> 
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>
> ---
patch looks sane to me,


Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

>  sound/soc/codecs/lpass-rx-macro.c | 74 +++++++++++++++----------------
>  1 file changed, 35 insertions(+), 39 deletions(-)
> 
> diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
> index a8fc842cc94ef..d7e51f02a9115 100644
> --- a/sound/soc/codecs/lpass-rx-macro.c
> +++ b/sound/soc/codecs/lpass-rx-macro.c
> @@ -1905,52 +1905,48 @@ static int rx_macro_digital_mute(struct snd_soc_dai *dai, int mute, int stream)
>  {
>  	struct snd_soc_component *component = dai->component;
>  	struct rx_macro *rx = snd_soc_component_get_drvdata(component);
> -	uint16_t j, reg, mix_reg, dsm_reg;
> -	u16 int_mux_cfg0, int_mux_cfg1;
> +	u32 port, j, reg, mix_reg, int_mux_cfg0, int_mux_cfg1;
> +	u32 mask, val;
>  	u8 int_mux_cfg0_val, int_mux_cfg1_val;
>  
> -	switch (dai->id) {
> -	case RX_MACRO_AIF1_PB:
> -	case RX_MACRO_AIF2_PB:
> -	case RX_MACRO_AIF3_PB:
> -	case RX_MACRO_AIF4_PB:
> -		for (j = 0; j < INTERP_MAX; j++) {
> -			reg = CDC_RX_RXn_RX_PATH_CTL(rx, j);
> -			mix_reg = CDC_RX_RXn_RX_PATH_MIX_CTL(rx, j);
> -			dsm_reg = CDC_RX_RXn_RX_PATH_DSM_CTL(rx, j);
> -
> -			if (mute) {
> -				snd_soc_component_update_bits(component, reg,
> -							      CDC_RX_PATH_PGA_MUTE_MASK,
> -							      CDC_RX_PATH_PGA_MUTE_ENABLE);
> -				snd_soc_component_update_bits(component, mix_reg,
> -							      CDC_RX_PATH_PGA_MUTE_MASK,
> -							      CDC_RX_PATH_PGA_MUTE_ENABLE);
> -			} else {
> -				snd_soc_component_update_bits(component, reg,
> -							      CDC_RX_PATH_PGA_MUTE_MASK, 0x0);
> -				snd_soc_component_update_bits(component, mix_reg,
> -							      CDC_RX_PATH_PGA_MUTE_MASK, 0x0);
> +	if (stream != SNDRV_PCM_STREAM_PLAYBACK)
> +		return 0;
> +
> +	for (j = 0; j < INTERP_MAX; j++) {
> +		reg = CDC_RX_RXn_RX_PATH_CTL(rx, j);
> +		mix_reg = CDC_RX_RXn_RX_PATH_MIX_CTL(rx, j);
> +
> +		mask = CDC_RX_PATH_PGA_MUTE_MASK;
> +		val = 0;
> +		if (mute)
> +			val |= CDC_RX_PATH_PGA_MUTE_ENABLE;
> +		if (rx->main_clk_users[j] > 0) {
> +			mask |= CDC_RX_PATH_CLK_EN_MASK;
> +			val |= CDC_RX_PATH_CLK_ENABLE;
> +		}
> +
> +		int_mux_cfg0 = CDC_RX_INP_MUX_RX_INT0_CFG0 + j * 8;
> +		int_mux_cfg1 = int_mux_cfg0 + 4;
> +		int_mux_cfg0_val = snd_soc_component_read(component, int_mux_cfg0);
> +		int_mux_cfg1_val = snd_soc_component_read(component, int_mux_cfg1);
> +
> +		for_each_set_bit(port, &rx->active_ch_mask[dai->id], RX_MACRO_PORTS_MAX) {
> +			if (((int_mux_cfg0_val & 0x0f) == port + INTn_1_INP_SEL_RX0) ||
> +			    ((int_mux_cfg0_val >> 4) == port + INTn_1_INP_SEL_RX0) ||
> +			    ((int_mux_cfg1_val >> 4) == port + INTn_1_INP_SEL_RX0)) {
> +				snd_soc_component_update_bits(component, reg, mask, val);
>  			}
>  
> -			int_mux_cfg0 = CDC_RX_INP_MUX_RX_INT0_CFG0 + j * 8;
> -			int_mux_cfg1 = int_mux_cfg0 + 4;
> -			int_mux_cfg0_val = snd_soc_component_read(component, int_mux_cfg0);
> -			int_mux_cfg1_val = snd_soc_component_read(component, int_mux_cfg1);
> -
> -			if (snd_soc_component_read(component, dsm_reg) & 0x01) {
> -				if (int_mux_cfg0_val || (int_mux_cfg1_val & 0xF0))
> -					snd_soc_component_update_bits(component, reg, 0x20, 0x20);
> -				if (int_mux_cfg1_val & 0x0F) {
> -					snd_soc_component_update_bits(component, reg, 0x20, 0x20);
> -					snd_soc_component_update_bits(component, mix_reg, 0x20,
> -								      0x20);
> +			if ((int_mux_cfg1_val & 0x0f) == port + INTn_2_INP_SEL_RX0) {
> +				snd_soc_component_update_bits(component, mix_reg, mask, val);
> +				/* main clock needs to be enabled for mix to be useful: */
> +				if (rx->main_clk_users[j] > 0) {
> +					snd_soc_component_update_bits(component, reg,
> +								      CDC_RX_PATH_CLK_EN_MASK,
> +								      CDC_RX_PATH_CLK_ENABLE);
>  				}
>  			}
>  		}
> -		break;
> -	default:
> -		break;
>  	}
>  	return 0;
>  }