linux-kernel - Re: [PATCH 4/9] ASoC: codecs: lpass-wsa-macro: fix path clock dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e20fc1f3-e5dc-4c06-863d-ca306758cbd8@oss.qualcomm.com>
Date: Wed, 19 Nov 2025 15:34:40 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Jonathan Marek <jonathan@...ek.ca>, linux-arm-msm@...r.kernel.org
Cc: Srinivas Kandagatla <srini@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "open list:QCOM AUDIO (ASoC) DRIVERS" <linux-sound@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/9] ASoC: codecs: lpass-wsa-macro: fix path clock
 dependencies



On 11/17/25 5:15 AM, Jonathan Marek wrote:
> "WSA_RX0_CLK",etc. are path clocks, but "WSA RX0",etc. are ports, and there
> isn't a correspondence between the ports and paths.
> For example "WSA RX0" port could be used by the "RX1 MIX" path.
> The problem becomes obvious when RX4,etc. ports are added.
> 
> Enabling the path clocks should depend on the path being enabled.
> 
> With this fix, the main path clock will be enabled whenever the path is
> active: previously using the mix ports only would only activate the mix
> path clock and no audio would play.
> 
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>


Tested-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
#on T14s
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

> ---
>  sound/soc/codecs/lpass-wsa-macro.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c
> index 06570e474c850..27c8c060cab19 100644
> --- a/sound/soc/codecs/lpass-wsa-macro.c
> +++ b/sound/soc/codecs/lpass-wsa-macro.c
> @@ -2496,10 +2496,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = {
>  	{"WSA RX_MIX0", NULL, "WSA RX_MIX0 MUX"},
>  	{"WSA RX_MIX1", NULL, "WSA RX_MIX1 MUX"},
>  
> -	{"WSA RX0", NULL, "WSA_RX0_CLK"},
> -	{"WSA RX1", NULL, "WSA_RX1_CLK"},
> -	{"WSA RX_MIX0", NULL, "WSA_RX_MIX0_CLK"},
> -	{"WSA RX_MIX1", NULL, "WSA_RX_MIX1_CLK"},
> +	{"WSA_RX INT0 MIX", NULL, "WSA_RX0_CLK"},
> +	{"WSA_RX INT1 MIX", NULL, "WSA_RX1_CLK"},
>  
>  	{"WSA_RX0 INP0", "RX0", "WSA RX0"},
>  	{"WSA_RX0 INP0", "RX1", "WSA RX1"},
> @@ -2529,6 +2527,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = {
>  	{"WSA_RX0 MIX INP", "RX1", "WSA RX1"},
>  	{"WSA_RX0 MIX INP", "RX_MIX0", "WSA RX_MIX0"},
>  	{"WSA_RX0 MIX INP", "RX_MIX1", "WSA RX_MIX1"},
> +	{"WSA_RX0 MIX INP", NULL, "WSA_RX0_CLK"},
> +	{"WSA_RX0 MIX INP", NULL, "WSA_RX_MIX0_CLK"},
>  	{"WSA_RX INT0 SEC MIX", NULL, "WSA_RX0 MIX INP"},
>  
>  	{"WSA_RX INT0 SEC MIX", NULL, "WSA_RX INT0 MIX"},
> @@ -2568,6 +2568,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = {
>  	{"WSA_RX1 MIX INP", "RX1", "WSA RX1"},
>  	{"WSA_RX1 MIX INP", "RX_MIX0", "WSA RX_MIX0"},
>  	{"WSA_RX1 MIX INP", "RX_MIX1", "WSA RX_MIX1"},
> +	{"WSA_RX1 MIX INP", NULL, "WSA_RX1_CLK"},
> +	{"WSA_RX1 MIX INP", NULL, "WSA_RX_MIX1_CLK"},
>  	{"WSA_RX INT1 SEC MIX", NULL, "WSA_RX1 MIX INP"},
>  
>  	{"WSA_RX INT1 SEC MIX", NULL, "WSA_RX INT1 MIX"},