linux-kernel - Re: [PATCH] platform/surface: acpi-notify: add WQ_PERCPU to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR3mVNQ6fT3apFnO@localhost.localdomain>
Date: Wed, 19 Nov 2025 16:46:28 +0100
From: Frederic Weisbecker <frederic@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Marco Crivellari <marco.crivellari@...e.com>,
	LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>,
	Maximilian Luz <luzmaximilian@...il.com>,
	Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH] platform/surface: acpi-notify: add WQ_PERCPU to
 alloc_workqueue users

Le Wed, Nov 19, 2025 at 04:44:32PM +0200, Ilpo Järvinen a écrit :
> On Wed, 19 Nov 2025, Marco Crivellari wrote:
> 
> > Hi,
> > On Wed, Nov 19, 2025 at 12:12 PM Ilpo Järvinen
> > <ilpo.jarvinen@...ux.intel.com> wrote:
> > >[...]
> > >
> > > For those system_wq changes you can follow a similar structure but alter
> > > it to match what is changed in the other interface.
> > >
> > > This seems already okay:
> > >
> > > "Replace system_wq with system_percpu_wq, keeping the same behavior."
> > 
> > Sorry it's just to check with you before sending a useless series.
> > Sounds good this, for the 2 system_percpu_wq commit logs?
> > I don't think there is more to add here, because it is a wq rename.
> > 
> > 
> > This patch continues the effort to refactor worqueue APIs, which has begun
> 
> Please fix that typo.
> 
> > with the change introducing new workqueues and a new alloc_workqueue flag:
> > 
> > commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> > commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> You should still have here the paragraph which explains the default change 
> briefly, similar to what was with the WQ_PERCPU description. I suggest you 
> just edit the wording in the paragraph taken from WQ_PERCPU changelog we 
> agreed on at the places where functions and arguments are different.

Thanks Ilpo for your changelogs change suggestions!

How does the following look like?

"""
platform: x86: Replace use of system_wq with system_percpu_wq

This patch continues the effort to refactor workqueue APIs, which has begun
with the changes introducing new workqueues and a new alloc_workqueue flag:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The point of the refactoring is to eventually alter the default behavior of
workqueues to become unbound by default so that their workload placement is
optimized by the scheduler.

Before that to happen after a careful review and conversion of each individual
case, workqueue users must be converted to the better named new workqueues with
no intended behaviour changes:

   system_wq -> system_percpu_wq
   system_unbound_wq -> systemd_dfl_wq

This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
removed in the future.
"""

-- 
Frederic Weisbecker
SUSE Labs