linux-kernel - Re: [PATCH] platform/surface: acpi-notify: add WQ_PERCPU to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ac7298-6053-b125-69b3-3ef198315fe8@linux.intel.com>
Date: Wed, 19 Nov 2025 16:44:32 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Marco Crivellari <marco.crivellari@...e.com>
cc: LKML <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>, 
    Frederic Weisbecker <frederic@...nel.org>, 
    Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
    Michal Hocko <mhocko@...e.com>, Maximilian Luz <luzmaximilian@...il.com>, 
    Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH] platform/surface: acpi-notify: add WQ_PERCPU to
 alloc_workqueue users

On Wed, 19 Nov 2025, Marco Crivellari wrote:

> Hi,
> On Wed, Nov 19, 2025 at 12:12 PM Ilpo Järvinen
> <ilpo.jarvinen@...ux.intel.com> wrote:
> >[...]
> >
> > For those system_wq changes you can follow a similar structure but alter
> > it to match what is changed in the other interface.
> >
> > This seems already okay:
> >
> > "Replace system_wq with system_percpu_wq, keeping the same behavior."
> 
> Sorry it's just to check with you before sending a useless series.
> Sounds good this, for the 2 system_percpu_wq commit logs?
> I don't think there is more to add here, because it is a wq rename.
> 
> 
> This patch continues the effort to refactor worqueue APIs, which has begun

Please fix that typo.

> with the change introducing new workqueues and a new alloc_workqueue flag:
> 
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

You should still have here the paragraph which explains the default change 
briefly, similar to what was with the WQ_PERCPU description. I suggest you 
just edit the wording in the paragraph taken from WQ_PERCPU changelog we 
agreed on at the places where functions and arguments are different.

> For more details see the Link tag below. Replace system_wq with
> system_percpu_wq, keeping the same behavior.
> 
> 
> Thanks!
> 
> 

-- 
 i.