linux-kernel - Re: [PATCH 1/2] rust: pin-init: fix broken rust doc link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mpbRV9kuqjTpur67Eq3ofMQjSvq=Q64BuyAtvg9RcCCg@mail.gmail.com>
Date: Wed, 19 Nov 2025 22:55:55 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benno Lossin <lossin@...nel.org>, Guillaume Gomez <guillaume1.gomez@...il.com>, 
	León Orell Valerian Liehr <me@...ase.dev>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, Fiona Behrens <me@...enk.dev>, 
	Alban Kurti <kurti@...icto.ai>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rust: pin-init: fix broken rust doc link

On Thu, Oct 16, 2025 at 11:17 PM Benno Lossin <lossin@...nel.org> wrote:
>
> Rust 1.92.0 warns when building the documentation that [`PinnedDrop`] is
> an invalid reference. This is correct and it's weird that it didn't warn
> before, so fix the link.
>
> Signed-off-by: Benno Lossin <lossin@...nel.org>

Benno asked me to pick these patches up for him this cycle.

Applied to `rust-next` -- thanks everyone!

    [ The reason is that it is hidden -- I had asked about that in the
      upstream PR that changed the behavior because I wasn't sure it was
      intentional (and thus whether we needed to fix this and other cases):

          https://github.com/rust-lang/rust/pull/147153#issuecomment-3395484636

      It turns out it was not, and it has been fixed for 1.92.0's upcoming
      release thanks to Guillaume and León. So we do not strictly need
      this patch and the other changes anymore:

          https://github.com/rust-lang/rust/pull/147809

      However, checking hidden/private items or, even better, a runtime
      toggle to be able to see those on the fly, is something that I think
      would be quite nice so I have had it in our usual lists for a while.
      Guillaume is open to the idea and perhaps experimenting with an
      implementation on our side first -- he asked me to open issues
      upstream:

          https://github.com/rust-lang/rust/issues/149105
          https://github.com/rust-lang/rust/issues/149106

        - Miguel ]

Cc'd León as well, who I should have probably Cc'd originally too.

Cheers,
Miguel