linux-kernel - Re: [PATCH] crypto: rng - Combine two seq_printf() calls into one in crypto_rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR1LcMOO0B6qUdOX@gondor.apana.org.au>
Date: Wed, 19 Nov 2025 12:45:36 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-crypto@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: rng - Combine two seq_printf() calls into one in
 crypto_rng_show()

On Mon, Nov 10, 2025 at 04:56:10PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 10 Nov 2025 16:45:13 +0100
> 
> A bit of data was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  crypto/rng.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/crypto/rng.c b/crypto/rng.c
> index ee1768c5a400..479c4ac6fb6c 100644
> --- a/crypto/rng.c
> +++ b/crypto/rng.c
> @@ -81,8 +81,7 @@ static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>  	__maybe_unused;
>  static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>  {
> -	seq_printf(m, "type         : rng\n");
> -	seq_printf(m, "seedsize     : %u\n", seedsize(alg));
> +	seq_printf(m, "type         : rng\nseedsize     : %u\n", seedsize(alg));

This makes the code look worse and appears to be an optimisation
that isn't really needed.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt