linux-kernel - Re: [PATCH] crypto: rng - Combine two seq_printf() calls into one in crypto_rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af38ab0e-79b8-432d-a923-16d2af129154@web.de>
Date: Wed, 19 Nov 2025 11:16:22 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Herbert Xu <herbert@...dor.apana.org.au>, linux-crypto@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Neil Horman <nhorman@...driver.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: rng - Combine two seq_printf() calls into one in
 crypto_rng_show()

…>> +++ b/crypto/rng.c
>> @@ -81,8 +81,7 @@ static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>>  	__maybe_unused;
>>  static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>>  {
>> -	seq_printf(m, "type         : rng\n");
>> -	seq_printf(m, "seedsize     : %u\n", seedsize(alg));
>> +	seq_printf(m, "type         : rng\nseedsize     : %u\n", seedsize(alg));
> 
> This makes the code look worse and appears to be an optimisation
> that isn't really needed.

Would you expect to specify still two string literals at such a source code place?

Regards,
Markus