linux-kernel - Re: [PATCH next] rtc: atcrtc100: Fix signedness bug in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR1uAuEtucZ11VMd@stanley.mountain>
Date: Wed, 19 Nov 2025 10:13:06 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: CL Wang <cl634@...estech.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] rtc: atcrtc100: Fix signedness bug in probe()

On Wed, Nov 19, 2025 at 10:35:23AM +0800, CL Wang wrote:
> On Tue, Nov 18, 2025 at 01:48:56PM +0300, Dan Carpenter wrote:
> 
> Hi Dan,
> 
> Thank you for pointing out the issue and for providing the fix.
> 
> You're absolutely correct that using an unsigned type for alarm_irq
> prevents proper error handling when platform_get_irq() returns a
> negative value. I will apply your patch and also review other return
> value checks to ensure there are no similar issues elsewhere.
> 
> Thank you again for your detailed review and suggestions.
> 

You're welcome.  These are just Smatch warnings.  Nothing super
major.

https://github.com/error27/smatch
https://github.com/error27/smatch/blob/master/Documentation/smatch.rst

regards,
dan carpenter