linux-kernel - Re: [PATCH 1/2] PCI/pwrctrl: tc9563: Enforce I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MeaGx6MR1wEo4ia7ovDRcJMH3H3sjyXQEN_cxoJ5q+dXQ@mail.gmail.com>
Date: Thu, 20 Nov 2025 07:12:50 -0600
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
Cc: bhelgaas@...gle.com, brgl@...ev.pl, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, krishna.chundru@....qualcomm.com, 
	Manivannan Sadhasivam <mani@...nel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] PCI/pwrctrl: tc9563: Enforce I2C dependency

On Thu, 20 Nov 2025 07:51:15 +0100, Manivannan Sadhasivam
<manivannan.sadhasivam@....qualcomm.com> said:
> This driver depends on the I2C interface to configure the switch. So
> enforce the dependency in Kconfig so that the I2C interface is selected
> appropriately. This also avoids the build issues like the one reported by
> the LKP bot:
>
>    alpha-linux-ld: alpha-linux-ld: DWARF error: could not find abbrev number 14070
>    drivers/pci/pwrctrl/pci-pwrctrl-tc9563.o: in function `tc9563_pwrctrl_remove':
>>> (.text+0x4c): undefined reference to `i2c_unregister_device'
>>> alpha-linux-ld: (.text+0x50): undefined reference to `i2c_unregister_device'
>>> alpha-linux-ld: (.text+0x60): undefined reference to `i2c_put_adapter'
>    alpha-linux-ld: (.text+0x64): undefined reference to `i2c_put_adapter'
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511200555.M4TX84jK-lkp@intel.com
> Signed-off-by: Manivannan Sadhasivam <mani@...nel.org>
> ---
>  drivers/pci/pwrctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> index b43fdf052d37..e0f999f299bb 100644
> --- a/drivers/pci/pwrctrl/Kconfig
> +++ b/drivers/pci/pwrctrl/Kconfig
> @@ -26,6 +26,7 @@ config PCI_PWRCTRL_TC9563
>  	tristate "PCI Power Control driver for TC9563 PCIe switch"
>  	select PCI_PWRCTRL
>  	default m if ARCH_QCOM
> +	depends on I2C
>  	help
>  	  Say Y here to enable the PCI Power Control driver of TC9563 PCIe
>  	  switch.
> --
> 2.48.1
>
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>