linux-kernel - Re: [PATCH] drm: sti: fix device leaks at component probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR8T4jbp9hr04cre@hovoldconsulting.com>
Date: Thu, 20 Nov 2025 14:13:06 +0100
From: Johan Hovold <johan@...nel.org>
To: Raphaël Gallais-Pou <rgallaispou@...il.com>
Cc: Alain Volmat <alain.volmat@...s.st.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@...labora.com>
Subject: Re: [PATCH] drm: sti: fix device leaks at component probe

On Tue, Nov 04, 2025 at 12:21:27PM +0100, Johan Hovold wrote:
> On Fri, Oct 31, 2025 at 06:10:46PM +0100, Raphaël Gallais-Pou wrote:
> 
> > Le Mon, Sep 22, 2025 at 02:20:12PM +0200, Johan Hovold a écrit :
> > > Make sure to drop the references taken to the vtg devices by
> > > of_find_device_by_node() when looking up their driver data during
> > > component probe.
> > 
> > Markus suggested “Prevent device leak in of_vtg_find()” as commit
> > summary.
> 
> Markus has gotten himself banned from the mailing lists some years ago
> and even if he is now back with a new mail address most of us still
> ignore him.
> 
> I prefer the Subject as it stands since it captures when the leaks
> happens, but I don't mind mentioning of_vtg_find() instead if you
> insist.

Can this one be picked up for 6.19 or do you want me to respin?

> > > Note that holding a reference to a platform device does not prevent its
> > > driver data from going away so there is no point in keeping the
> > > reference after the lookup helper returns.
> > > 
> > > Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure")
> > > Cc: stable@...r.kernel.org	# 4.16
> > > Cc: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> > > Signed-off-by: Johan Hovold <johan@...nel.org>

Johan