linux-kernel - Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120135920cfea853d@mail.local>
Date: Thu, 20 Nov 2025 14:59:20 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: ot_shunxi.zhang@...iatek.com
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Sean Wang <sean.wang@...iatek.com>, Lee Jones <lee@...nel.org>,
	Vince-WL.Liu@...iatek.com, sirius.wang@...iatek.com,
	Jh.Hsu@...iatek.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver
 structure

On 20/11/2025 20:17:59+0800, ot_shunxi.zhang@...iatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> 
> This is a cosmetic change to improve code consistency.
> 

But, is it?

> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 692c00ff544b..b8f44a00de5d 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -345,7 +345,7 @@ static struct platform_driver mtk_rtc_driver = {
>  		.of_match_table = mt6397_rtc_of_match,
>  		.pm = &mt6397_pm_ops,
>  	},
> -	.probe	= mtk_rtc_probe,

I guess the original author wanted to align with the members of the
.drivers struct above. I won't take a patch to change just that as the
next guys wanting to improve his KPIs will do the exact opposite.


> +	.probe = mtk_rtc_probe,
>  };
>  
>  module_platform_driver(mtk_rtc_driver);
> -- 
> 2.45.2
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com