linux-kernel - Re: [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <176364782296.1171084.17820068069366614095.robh@kernel.org>
Date: Thu, 20 Nov 2025 08:14:55 -0600
From: Rob Herring <robh@...nel.org>
To: ot_shunxi.zhang@...iatek.com
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>, 
 Sean Wang <sean.wang@...iatek.com>, linux-kernel@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
 linux-mediatek@...ts.infradead.org, Eddie Huang <eddie.huang@...iatek.com>, 
 Vince-WL.Liu@...iatek.com, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Lee Jones <lee@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
 devicetree@...r.kernel.org, sirius.wang@...iatek.com, Jh.Hsu@...iatek.com, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit
 definitions and shutdown handling


On Thu, 20 Nov 2025 20:17:56 +0800, ot_shunxi.zhang@...iatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> 
> (1) Add new bits definitions for RTC_BBPU register.
> (2) Add new functions to reset the BBPU alarm status in mt6397 RTC driver
> (3) Add mtk_rtc_shutdown function to handle RTC shutdown events.
> (4) For the V1 version comments, the following modifications are made:
> (4.1)the formatting changes are separated into a distinct patch.
> (4.2)Since the rtc-mt6397.c file is a fusion of multiple RTC drivers
> for the mt6358, mt6359, and mt6357 RTCs, the definitions of certain bits
> in the RTC_BBPU register differ among these RTCs. The mt6359 supports
> the alarm status bit, while both mt6358 and mt6357 do not. Therefore,
> the alarm-sta-supported property is added in the mt6359.dtsi file to
> differentiate between the different RTCs.
> (4.3)Additionally, the operation to disable IRQ in the shutdown function
> is removed.
> 
> Shunxi Zhang (5):
>   mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition
>   mfd: mt6397: Add bit definitions and struct members to support alarm
>     status
>   rtc: mt6397: Fix formatting of platform driver structure
>   rtc: mt6397: Add BBPU alarm status reset and shutdown handling
>   arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC
>     node
> 
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi |  1 +
>  drivers/rtc/rtc-mt6397.c                 | 32 +++++++++++++++++++++++-
>  include/linux/mfd/mt6397/rtc.h           |  5 +++-
>  3 files changed, 36 insertions(+), 2 deletions(-)
> 
> --
> 2.45.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20251119 (exact match)
 Base: tags/next-20251119 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/mediatek/' for 20251120121805.6775-1-ot_shunxi.zhang@...iatek.com:

arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-kontron-3-5-sbc-i1200.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8370-genio-510-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-demo.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8370-grinn-genio-510-sbc.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku3.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku0.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8390-grinn-genio-700-sbc.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-evb.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku2.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml