linux-kernel - Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f65506e6-ac29-449e-86b3-540c23ca6119@kernel.org>
Date: Thu, 20 Nov 2025 15:12:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: iansdannapel@...il.com, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-fpga@...r.kernel.org, mdf@...nel.org,
 yilun.xu@...el.com, trix@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, heiko@...ech.de, neil.armstrong@...aro.org,
 mani@...nel.org, kever.yang@...k-chips.com, dev@...l-k.io
Subject: Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming
 bindings

On 19/11/2025 19:47, iansdannapel@...il.com wrote:
> From: Ian Dannapel <iansdannapel@...il.com>
> 
> Add device tree bindings documentation for configuring Efinix FPGA
> using serial SPI passive programming mode.
> 
> Signed-off-by: Ian Dannapel <iansdannapel@...il.com>
> ---
>  .../bindings/fpga/efinix,trion-spi.yaml       | 77 +++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/efinix,trion-spi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/efinix,trion-spi.yaml b/Documentation/devicetree/bindings/fpga/efinix,trion-spi.yaml
> new file mode 100644
> index 000000000000..9ac37e5e5094
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/efinix,trion-spi.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/efinix,spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Efinix SPI FPGA Manager
> +
> +maintainers:
> +  - Ian Dannapel <iansdannapel@...il.com>
> +
> +description: |
> +  Efinix FPGAs (Trion, Topaz, and Titanium families) support loading bitstreams
> +  through "SPI Passive Mode".
> +  Note: Additional pins hogs for bus width configuration must be set
> +  elsewhere, if necessary. Only bus width 1x serial is supported.
> +
> +  References:
> +  - https://www.efinixinc.com/docs/an006-configuring-trion-fpgas-v6.3.pdf
> +  - https://www.efinixinc.com/docs/an033-configuring-titanium-fpgas-v2.8.pdf
> +  - https://www.efinixinc.com/docs/an061-configuring-topaz-fpgas-v1.1.pdf
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - efinix,trion-spi
> +      - efinix,titanium-spi
> +      - efinix,topaz-spi


Nothing improved. You received comments about this - twice or more even
- so I feel like you just don't care about review.

NAK

Best regards,
Krzysztof