linux-kernel - Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKrir7hCGEdwZihgV8-JaXq1EbzQCvpJXcG_FEmDYEoJqUpbcg@mail.gmail.com>
Date: Thu, 20 Nov 2025 16:55:18 +0100
From: Ian Dannapel <iansdannapel@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-fpga@...r.kernel.org, mdf@...nel.org, yilun.xu@...el.com, 
	trix@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	heiko@...ech.de, neil.armstrong@...aro.org, mani@...nel.org, 
	kever.yang@...k-chips.com, dev@...l-k.io
Subject: Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings

Hello Krzysztof,

On Thu, Nov 20, 2025 at 3:13 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - efinix,trion-spi
> > +      - efinix,titanium-spi
> > +      - efinix,topaz-spi
>
>
> Nothing improved. You received comments about this - twice or more even
> - so I feel like you just don't care about review.
Sorry I am lost here, this is based on a similar driver, but it is
probably very outdated.
So the fallback pattern would be okay? Eg:
items:
      - enum:
          - efinix,trion-config
          - efinix,titanium-config
          - efinix,topaz-config
      - const: efinix,fpga-config
Or would a single compatible be better since currently from the
drivers perspective there is
no difference in hardware?
> NAK
>
> Best regards,
> Krzysztof
Thanks for review
Best regards,
Ian