linux-kernel - Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d05daf50-dee2-4fb9-a4b4-4ef68edfe384@kernel.org>
Date: Thu, 20 Nov 2025 17:42:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ian Dannapel <iansdannapel@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-fpga@...r.kernel.org, mdf@...nel.org, yilun.xu@...el.com,
 trix@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 heiko@...ech.de, neil.armstrong@...aro.org, mani@...nel.org,
 kever.yang@...k-chips.com, dev@...l-k.io
Subject: Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming
 bindings

On 20/11/2025 16:55, Ian Dannapel wrote:
> Hello Krzysztof,
> 
> On Thu, Nov 20, 2025 at 3:13 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - efinix,trion-spi
>>> +      - efinix,titanium-spi
>>> +      - efinix,topaz-spi
>>
>>
>> Nothing improved. You received comments about this - twice or more even
>> - so I feel like you just don't care about review.
> Sorry I am lost here, this is based on a similar driver, but it is
> probably very outdated.
> So the fallback pattern would be okay? Eg:
> items:
>       - enum:
>           - efinix,trion-config
>           - efinix,titanium-config
>           - efinix,topaz-config
>       - const: efinix,fpga-config
> Or would a single compatible be better since currently from the
> drivers perspective there is
> no difference in hardware?

Almost, because I think you asked about this and I instead asked to use
one specific device as the fallback. Choose the oldest device and use it
the fallback for two others. There is plenty of examples - including
example-schema - using it with oneOf syntax.

Best regards,
Krzysztof