linux-kernel - Re: [PATCH v6 1/2] regulator: dt-bindings: Add MAX77675 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120150343.GA1256330-robh@kernel.org>
Date: Thu, 20 Nov 2025 09:03:43 -0600
From: Rob Herring <robh@...nel.org>
To: Joan-Na-adi <joan.na.devcode@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Joan Na <joan.na@...log.com>
Subject: Re: [PATCH v6 1/2] regulator: dt-bindings: Add MAX77675 regulator

On Thu, Nov 20, 2025 at 09:54:48PM +0900, Joan-Na-adi wrote:
> From: Joan Na <joan.na@...log.com>
> 
> Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator.
> 
> Signed-off-by: Joan Na <joan.na@...log.com>
> ---
>  .../bindings/regulator/adi,max77675.yaml      | 188 ++++++++++++++++++
>  1 file changed, 188 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/adi,max77675.yaml b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> new file mode 100644
> index 000000000000..54cbbd59ff5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml
> @@ -0,0 +1,188 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,max77675.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77675 PMIC Regulator
> +
> +maintainers:
> +  - Joan Na <joan.na@...log.com>
> +
> +description:
> +  The MAX77675 is a Power Management IC providing four switching buck
> +  regulators (SBB0–SBB3) accessible via I2C. It supports configuration
> +  of output voltages and enable controls for each regulator.
> +
> +allOf:
> +  - $ref: /schemas/input/input.yaml
> +  - $ref: /schemas/pinctrl/pincfg-node.yaml
> +
> +properties:
> +  compatible:
> +    const: adi,max77675
> +
> +  reg:
> +    maxItems: 1
> +
> +  reset-time-sec:
> +    description: Manual reset time in seconds
> +    enum: [4, 8, 12, 16]
> +    default: 4
> +
> +  bias-disable:
> +    type: boolean
> +    description: Disable internal pull-up for EN pin
> +    default: false

'default' does not make sense for boolean properties. default is how 
should the s/w handle the property not being present. That's always 
false for booleans and can't possibly be true as you have below.

With those dropped everywhere,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>