linux-kernel - Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f942b9f-ce85-4e02-9317-3aef1dccd1c9@suse.com>
Date: Thu, 20 Nov 2025 17:45:10 +0200
From: Nikolay Borisov <nik.borisov@...e.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Yazen.Ghannam@....com, linux-edac@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor_bits



On 11/20/25 17:41, Borislav Petkov wrote:
> On Tue, Nov 18, 2025 at 02:36:08PM +0200, Nikolay Borisov wrote:
>> Fair point, but bitwise xor is the lowest possible operation, I guess we
>> care about the higher-level effect, which is calculating parity.
> 
> ... in a function which "Calculate hash for each Bank bit."?
> 
> I don't think it matters either way. This is converting the DRAM addressing
> scheme into normalized addresses so as long as it is clear what happens
> there...
> 


So are you saying the patch should be dropped altogether or that the 
changelog should be reworded?  The way I see it, the parity for the 
given bank's col/row are calculated and this then is used into 
calculating the hash.