linux-kernel - Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120155718.GCaR86XjhRyHTrkZYl@fat_crate.local>
Date: Thu, 20 Nov 2025 16:57:18 +0100
From: Borislav Petkov <bp@...en8.de>
To: Nikolay Borisov <nik.borisov@...e.com>
Cc: Yazen.Ghannam@....com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor_bits

On Thu, Nov 20, 2025 at 05:45:10PM +0200, Nikolay Borisov wrote:
> So are you saying the patch should be dropped altogether or that the
> changelog should be reworded?  The way I see it, the parity for the given
> bank's col/row are calculated and this then is used into calculating the
> hash.

For you it is the parity, for someone else it is XORing the bits. All boiling
down to the same operation.

The only upside to the change is the removal of the function and using the
builtin. Which begs the question, do all compilers support that builtin?

If yes, then you can reword and resend.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette