lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
 <SEYPR06MB51342B45A91BB4CDA4302B519DD4A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Thu, 20 Nov 2025 03:20:59 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Conor Dooley <conor@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Andrew Jeffery <andrew@...id.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: [PATCH net-next] dt-bindings: net: aspeed: add AST2700 MDIO
 compatible

Hi Conor Dooley,

Thank your for your reply.

> >    The ASPEED AST2600 MDIO controller is the third iteration of ASPEED's
> MDIO
> >    bus register interface, this time also separating out the controller from
> the
> >    MAC.
> > +  The ASPEED AST2700 MDIO controller is similar to the AST2600's.
> 
> This statement disagrees with your commit message that claims functionally
> identical, and implies that the 2700 supports some extra features or whatever.
> I think I'd drop this entirely from the patch, rather than try to reword it.
> Remove it and then:
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> pw-bot: changes-requested
> 

Agreed.
I will remove this description in next version.

Thanks,
Jacky


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ