linux-kernel - Re: [PATCH net-next] dt-bindings: net: aspeed: add AST2700 MDIO compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251119-gooey-wifi-413598a8a1d7@spud>
Date: Wed, 19 Nov 2025 18:41:05 +0000
From: Conor Dooley <conor@...nel.org>
To: Jacky Chou <jacky_chou@...eedtech.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	Andrew Jeffery <andrew@...id.au>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: aspeed: add AST2700 MDIO
 compatible

On Mon, Nov 17, 2025 at 03:30:18PM +0800, Jacky Chou wrote:
> Add "aspeed,ast2700-mdio" compatible to the binding schema with a fallback
> to "aspeed,ast2600-mdio".
> 
> Although the MDIO controller on AST2700 is functionally the same as the
> one on AST2600, it's good practice to add a SoC-specific compatible for
> new silicon. This allows future driver updates to handle any 2700-specific
> integration issues without requiring devicetree changes or complex
> runtime detection logic.
> 
> For now, the driver continues to bind via the existing
> "aspeed,ast2600-mdio" compatible, so no driver changes are needed.
> 
> Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
> ---
>  Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index d6ef468495c5..1c90e7c15a44 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -13,13 +13,19 @@ description: |+
>    The ASPEED AST2600 MDIO controller is the third iteration of ASPEED's MDIO
>    bus register interface, this time also separating out the controller from the
>    MAC.
> +  The ASPEED AST2700 MDIO controller is similar to the AST2600's.

This statement disagrees with your commit message that claims
functionally identical, and implies that the 2700 supports some extra
features or whatever.
I think I'd drop this entirely from the patch, rather than try to reword
it. Remove it and then:
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
pw-bot: changes-requested

>  allOf:
>    - $ref: mdio.yaml#
>  
>  properties:
>    compatible:
> -    const: aspeed,ast2600-mdio
> +    oneOf:
> +      - const: aspeed,ast2600-mdio
> +      - items:
> +          - enum:
> +              - aspeed,ast2700-mdio
> +          - const: aspeed,ast2600-mdio
>  
>    reg:
>      maxItems: 1
> 
> ---
> base-commit: c9dfb92de0738eb7fe6a591ad1642333793e8b6e
> change-id: 20251117-aspeed_mdio_ast2700-aa089c4f0474
> 
> Best regards,
> -- 
> Jacky Chou <jacky_chou@...eedtech.com>
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)