linux-kernel - Re: [PATCH v2 03/23] KVM: selftests: Extend vmx_close_while_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR-p-2yEZPVMYniU@google.com>
Date: Thu, 20 Nov 2025 15:53:31 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Jim Mattson <jmattson@...gle.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/23] KVM: selftests: Extend vmx_close_while_nested_test
 to cover SVM

On Tue, Oct 21, 2025, Yosry Ahmed wrote:
> Add SVM L1 code to run the nested guest, and allow the test to run with
> SVM as well as VMX.
> 
> Reviewed-by: Jim Mattson <jmattson@...gle.com>
> 
> Signed-off-by: Yosry Ahmed <yosry.ahmed@...ux.dev>
> ---
>  tools/testing/selftests/kvm/Makefile.kvm      |  2 +-
>  ...ested_test.c => close_while_nested_test.c} | 42 +++++++++++++++----
>  2 files changed, 35 insertions(+), 9 deletions(-)
>  rename tools/testing/selftests/kvm/x86/{vmx_close_while_nested_test.c => close_while_nested_test.c} (64%)
> 
> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> index acfa22206e6f3..e70a844a52bdc 100644
> --- a/tools/testing/selftests/kvm/Makefile.kvm
> +++ b/tools/testing/selftests/kvm/Makefile.kvm
> @@ -112,7 +112,7 @@ TEST_GEN_PROGS_x86 += x86/ucna_injection_test
>  TEST_GEN_PROGS_x86 += x86/userspace_io_test
>  TEST_GEN_PROGS_x86 += x86/userspace_msr_exit_test
>  TEST_GEN_PROGS_x86 += x86/vmx_apic_access_test
> -TEST_GEN_PROGS_x86 += x86/vmx_close_while_nested_test
> +TEST_GEN_PROGS_x86 += x86/close_while_nested_test

Unless someone vehemently objects, I'm going to tweak this to nested_close_kvm_test,
and keep Makefile.kvm sorted.

>  TEST_GEN_PROGS_x86 += x86/vmx_dirty_log_test
>  TEST_GEN_PROGS_x86 += x86/vmx_exception_with_invalid_guest_state
>  TEST_GEN_PROGS_x86 += x86/vmx_msrs_test
> diff --git a/tools/testing/selftests/kvm/x86/vmx_close_while_nested_test.c b/tools/testing/selftests/kvm/x86/close_while_nested_test.c
> similarity index 64%
> rename from tools/testing/selftests/kvm/x86/vmx_close_while_nested_test.c
> rename to tools/testing/selftests/kvm/x86/close_while_nested_test.c
> index dad988351493e..cf5f24c83c448 100644
> --- a/tools/testing/selftests/kvm/x86/vmx_close_while_nested_test.c
> +++ b/tools/testing/selftests/kvm/x86/close_while_nested_test.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * vmx_close_while_nested
> + * close_while_nested_test

And of course zap this :-)