linux-kernel - Re: [PATCH v2 05/23] KVM: selftests: Move nested invalid CR3 check to its own test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR-qWN9uIX3fl5QX@google.com>
Date: Thu, 20 Nov 2025 15:55:04 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Jim Mattson <jmattson@...gle.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/23] KVM: selftests: Move nested invalid CR3 check to
 its own test

On Tue, Oct 21, 2025, Yosry Ahmed wrote:
> vmx_tsc_adjust_test currently verifies that a nested VMLAUNCH fails with
> an invalid CR3. This is irrelevant to TSC scaling, move it to a
> standalone test.
> 
> Signed-off-by: Yosry Ahmed <yosry.ahmed@...ux.dev>
> ---
>  tools/testing/selftests/kvm/Makefile.kvm      |  1 +
>  .../kvm/x86/nested_invalid_cr3_test.c         | 81 +++++++++++++++++++
>  .../selftests/kvm/x86/vmx_tsc_adjust_test.c   | 10 ---
>  3 files changed, 82 insertions(+), 10 deletions(-)
>  create mode 100644 tools/testing/selftests/kvm/x86/nested_invalid_cr3_test.c
> 
> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> index bb2ff7927ef57..b78700c574fc7 100644
> --- a/tools/testing/selftests/kvm/Makefile.kvm
> +++ b/tools/testing/selftests/kvm/Makefile.kvm
> @@ -88,6 +88,7 @@ TEST_GEN_PROGS_x86 += x86/kvm_pv_test
>  TEST_GEN_PROGS_x86 += x86/kvm_buslock_test
>  TEST_GEN_PROGS_x86 += x86/monitor_mwait_test
>  TEST_GEN_PROGS_x86 += x86/msrs_test
> +TEST_GEN_PROGS_x86 += x86/nested_invalid_cr3_test

Almost.  A. B. C. D. I? E.  :-D

>  TEST_GEN_PROGS_x86 += x86/nested_emulation_test
>  TEST_GEN_PROGS_x86 += x86/nested_exceptions_test
>  TEST_GEN_PROGS_x86 += x86/platform_info_test
> diff --git a/tools/testing/selftests/kvm/x86/nested_invalid_cr3_test.c b/tools/testing/selftests/kvm/x86/nested_invalid_cr3_test.c
> new file mode 100644
> index 0000000000000..b9853ab532cfe
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/x86/nested_invalid_cr3_test.c
> @@ -0,0 +1,81 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * nested_invalid_cr3_test

Boooooh.