[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <17085f43-22fc-4590-bf42-6869ca3d7bd3@gmail.com>
Date: Thu, 20 Nov 2025 13:02:39 +0530
From: tessolveupstream@...il.com
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for
QCS615 talos evk board
On 19-11-2025 15:55, Dmitry Baryshkov wrote:
> On Tue, Nov 18, 2025 at 06:38:14PM +0530, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
>>
>> The Carrier Board supports several display configurations, HDMI and
>> LVDS. Both configurations use the same base hardware, with the display
>> selection controlled by a DIP switch.
>>
>> To avoid duplication, use an include file, talos-evk-cb.dtsi, which
>> defines the interfaces and peripherals common to both display
>> variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds)
>> can describe the selected display configuration.
>>
>> The initial device tree includes support for:
>> - CPU and memory
>> - UART
>> - GPIOs
>> - Regulators
>> - PMIC
>> - Early console
>> - AT24MAC602 EEPROM
>> - MCP2515 SPI to CAN
>> - ADV7535 DSI-to-HDMI bridge
>> - DisplayPort interface
>
> You got the question for v6, responded there but didn't update commit
> message. What is not enabled here? E.g. why isn't venus enabled?
In earlier patch, we have added 'Wi-Fi/BT and ethernet is not
supported'as a commit message. Later,based on
Krzysztof Kozlowski’s review comments, we removed the same.
Please find the below review comment for your reference.
https://lore.kernel.org/all/20251028053248.723560-1-tessolveupstream@gmail.com/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6
We are not clear whether 'Wi-Fi/BT and ethernet is not supported'
should be added back to the commit message or not.
Could you please confirm your preference?
Venus is enabled in this patch.
>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++
>> arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++
>> 4 files changed, 598 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi
>> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
>>
>
Powered by blists - more mailing lists