linux-kernel - Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46k4uvtoit5tty3ojh7da7yliqz27tdcscu2co5tuowy33uicc@v3f3cojpwvzp>
Date: Fri, 21 Nov 2025 18:46:19 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: tessolveupstream@...il.com
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for
 QCS615 talos evk board

On Thu, Nov 20, 2025 at 01:02:39PM +0530, tessolveupstream@...il.com wrote:
> 
> 
> On 19-11-2025 15:55, Dmitry Baryshkov wrote:
> > On Tue, Nov 18, 2025 at 06:38:14PM +0530, Sudarshan Shetty wrote:
> >> Add the device tree for the QCS615-based Talos EVK platform. The
> >> platform is composed of a System-on-Module following the SMARC
> >> standard, and a Carrier Board.
> >>
> >> The Carrier Board supports several display configurations, HDMI and
> >> LVDS. Both configurations use the same base hardware, with the display
> >> selection controlled by a DIP switch.
> >>
> >> To avoid duplication, use an include file, talos-evk-cb.dtsi, which
> >> defines the interfaces and peripherals common to both display
> >> variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds)
> >> can describe the selected display configuration.
> >>
> >> The initial device tree includes support for:
> >> - CPU and memory
> >> - UART
> >> - GPIOs
> >> - Regulators
> >> - PMIC
> >> - Early console
> >> - AT24MAC602 EEPROM
> >> - MCP2515 SPI to CAN
> >> - ADV7535 DSI-to-HDMI bridge
> >> - DisplayPort interface
> > 
> > You got the question for v6, responded there but didn't update commit
> > message. What is not enabled here? E.g. why isn't venus enabled?
> 
> In earlier patch, we have added 'Wi-Fi/BT and ethernet is not 
> supported'as a commit message. Later,based on 
> Krzysztof Kozlowski’s review comments, we removed the same. 
> Please find the below review comment for your reference.
> https://lore.kernel.org/all/20251028053248.723560-1-tessolveupstream@gmail.com/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6
> 
> We are not clear whether 'Wi-Fi/BT and ethernet is not supported'
> should be added back to the commit message or not. 
> Could you please confirm your preference?

If you are unsure, you can add this info to the cover letter. Or you can
write something like 'Ethernet and WiFi/BT are not (yet) supported.'.

> 
> Venus is enabled in this patch.

Ack, excuse me.

> > 
> >> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/Makefile           |   1 +
> >>  arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi  |  56 +++
> >>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++
> >>  arch/arm64/boot/dts/qcom/talos-evk.dts      |  94 ++++
> >>  4 files changed, 598 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi
> >>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> >>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
> >>
> > 
> 

-- 
With best wishes
Dmitry