linux-kernel - RE: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX deemphasis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59532EE10DF327B182892A9BB7D4A@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Thu, 20 Nov 2025 09:05:32 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, "Simek,
 Michal" <michal.simek@....com>, "Thinh.Nguyen@...opsys.com"
	<Thinh.Nguyen@...opsys.com>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX
 deemphasis

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, November 20, 2025 1:50 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>
> Cc: gregkh@...uxfoundation.org; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; Simek, Michal <michal.simek@....com>;
> Thinh.Nguyen@...opsys.com; p.zabel@...gutronix.de; linux-usb@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX
> deemphasis
>
> On Thu, Nov 20, 2025 at 01:00:36AM +0530, Radhey Shyam Pandey wrote:
> >  struct dwc3_xlnx {
> >     int                             num_clocks;
> > @@ -306,7 +307,7 @@ MODULE_DEVICE_TABLE(of, dwc3_xlnx_of_match);
> > static int dwc3_set_swnode(struct device *dev)  {
> >     struct device_node *np = dev->of_node, *dwc3_np;
> > -   struct property_entry props[2];
> > +   struct property_entry props[3];
> >     int prop_idx = 0, ret = 0;
> >
> >     dwc3_np = of_get_compatible_child(np, "snps,dwc3"); @@ -320,6
> > +321,10 @@ static int dwc3_set_swnode(struct device *dev)
> >     if (of_dma_is_coherent(dwc3_np))
> >             props[prop_idx++] = PROPERTY_ENTRY_U16("snps,gsbuscfg0-
> reqinfo",
> >                                                    0xffff);
> > +   if (of_device_is_compatible(np, "xlnx,versal2-mmi-dwc3"))
>
> Don't sprinkle compatibles all over the code - it does not scale. You have driver
> match data for that.

Sure, in v2 will use match data flag to specify if TX deemphasis need
to be reprogrammed.

Thanks,
Radhey