linux-kernel - Re: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX deemphasis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120-polite-ginger-tarantula-08c98c@kuoka>
Date: Thu, 20 Nov 2025 09:19:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, michal.simek@....com, Thinh.Nguyen@...opsys.com, 
	p.zabel@...gutronix.de, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, git@....com
Subject: Re: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX
 deemphasis

On Thu, Nov 20, 2025 at 01:00:36AM +0530, Radhey Shyam Pandey wrote:
>  struct dwc3_xlnx {
>  	int				num_clocks;
> @@ -306,7 +307,7 @@ MODULE_DEVICE_TABLE(of, dwc3_xlnx_of_match);
>  static int dwc3_set_swnode(struct device *dev)
>  {
>  	struct device_node *np = dev->of_node, *dwc3_np;
> -	struct property_entry props[2];
> +	struct property_entry props[3];
>  	int prop_idx = 0, ret = 0;
>  
>  	dwc3_np = of_get_compatible_child(np, "snps,dwc3");
> @@ -320,6 +321,10 @@ static int dwc3_set_swnode(struct device *dev)
>  	if (of_dma_is_coherent(dwc3_np))
>  		props[prop_idx++] = PROPERTY_ENTRY_U16("snps,gsbuscfg0-reqinfo",
>  						       0xffff);
> +	if (of_device_is_compatible(np, "xlnx,versal2-mmi-dwc3"))

Don't sprinkle compatibles all over the code - it does not scale. You
have driver match data for that.

Best regards,
Krzysztof