linux-kernel - Re: [PATCH] kho: free chunks using free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mafs0qztt2h5x.fsf@kernel.org>
Date: Thu, 20 Nov 2025 10:21:30 +0100
From: Pratyush Yadav <pratyush@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Pratyush Yadav <pratyush@...nel.org>,  kexec@...ts.infradead.org,
  linux-mm@...ck.org,  Alexander Graf <graf@...zon.com>,  Andrew Morton
 <akpm@...ux-foundation.org>,  David Matlack <dmatlack@...gle.com>,  Mike
 Rapoport <rppt@...nel.org>,  Pasha Tatashin <pasha.tatashin@...een.com>,
  LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kho: free chunks using free_page() instead of kfree()

On Wed, Nov 19 2025, Markus Elfring wrote:

> …
>> When the commit switched to using the buddy allocator directly, it
>> missed updating kho_mem_ser_free() to use free_page() instead of
>> kfree().
>
> Would another imperative wording become helpful for an improved change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94

"the commit" here refers to the commit fa759cd75bce5 ("kho: allocate
metadata directly from the buddy allocator"), not "this commit"/"this
patch". I figured that can be understood from the context and I won't
need to spell the whole thing out again.

I don't understand the technicalities of the English grammar so well,
but IIUC imperative mood is used in sentences that give a command. This
paragraph talks about a past event.

Anyway, if you have something better, happy to take suggestions.

-- 
Regards,
Pratyush Yadav