[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b9f4103d8de37574a116164c50ac7e1bd09be80d.camel@linaro.org>
Date: Thu, 20 Nov 2025 10:04:20 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Peter Griffin <peter.griffin@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Tudor
Ambarus <tudor.ambarus@...aro.org>, Michael Turquette
<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Sam Protsenko
<semen.protsenko@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>
Cc: Will McVicker <willmcvicker@...gle.com>, Krzysztof Kozlowski
<krzk@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
kernel-team@...roid.com
Subject: Re: [PATCH v5 1/4] dt-bindings: clock: google,gs101-clock: add
samsung,sysreg property as required
On Fri, 2025-11-14 at 14:16 +0000, Peter Griffin wrote:
> Each CMU (with the exception of cmu_top) has a corresponding sysreg bank
> that contains the BUSCOMPONENT_DRCG_EN and optional MEMCLK registers.
> The BUSCOMPONENT_DRCG_EN register enables dynamic root clock gating of
> bus components and MEMCLK gates the sram clock.
>
> Now the clock driver supports automatic clock mode, to fully enable dynamic
> root clock gating it is required to configure these registers. Update the
> bindings documentation so that all CMUs (with the exception of
> gs101-cmu-top) have samsung,sysreg as a required property.
>
> Note this is NOT an ABI break, as if the property isn't specified the
> clock driver will fallback to the current behaviour of not initializing
> the registers. The system still boots, but bus components won't benefit
> from dynamic root clock gating and dynamic power will be higher (which has
> been the case until now anyway).
>
> Additionally update the DT example to included the correct CMU size as
> registers in that region are used for automatic clock mode.
>
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> ---
> Changes in v5:
> - Invert the test for google,gs101-cmu-top (Andre)
Reviewed-by: André Draszik <andre.draszik@...aro.org>
Powered by blists - more mailing lists