linux-kernel - Re: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pl9bzd2g.fsf@bootlin.com>
Date: Fri, 21 Nov 2025 15:15:51 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Nicolas Ferre <nicolas.ferre@...rochip.com>,
  Alexandre Belloni <alexandre.belloni@...tlin.com>,  Claudiu Beznea
 <claudiu.beznea@...on.dev>,  Russell King <linux@...linux.org.uk>,
  linux-mtd@...ts.infradead.org,  linux-arm-kernel@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing

Hello Rob,

> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index 83ba4ebd02d4..e60998eb754b 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2306,7 +2306,7 @@ atmel_hsmc_nand_controller_init(struct atmel_hsmc_nand_controller *nc)
>  					 "atmel,nfc-sram", 0);
>  	if (!nc->sram.pool) {
>  		dev_err(nc->base.dev, "Missing SRAM\n");
> -		return -ENOMEM;
> +		return -EPROBE_DEFER;

I am totally fine with the idea of probe deferral, however I think the
policy is to avoid making noise when this happens. The dev_err() call is
no longer relevant there. You can either lower it to dev_dbg() manually
or, at your convenience, return with:

   return dev_err_probe(nc->base.dev, "Missing SRAM\n", -EPROBE_DEFER);

Thanks,
Miquèl