linux-kernel - Re: [PATCH v2 2/3] ARM: at91: Move PM init functions to .init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ece2d53c-3e16-4e5e-9bb9-3ed7bb362b7b@tuxon.dev>
Date: Sat, 22 Nov 2025 17:37:31 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Rob Herring <robh@...nel.org>, Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Russell King <linux@...linux.org.uk>
Cc: linux-mtd@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: at91: Move PM init functions to .init_late
 hook

Hi, Rob,

On 11/20/25 23:37, Rob Herring wrote:
> Move the AT91 PM init functions to .init_late hook to ensure driver
> dependencies have probed.
> 
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

'From: Rob Herring <robh@...nel.org>' != 'Signed-off-by: Rob Herring (Arm)
<robh@...nel.org>


> ---
> v2:
>  - new patch
> ---
>  arch/arm/mach-at91/at91rm9200.c | 3 +--
>  arch/arm/mach-at91/at91sam9.c   | 3 +--
>  arch/arm/mach-at91/sam9x60.c    | 3 +--
>  arch/arm/mach-at91/sam9x7.c     | 3 +--
>  arch/arm/mach-at91/sama5.c      | 2 +-
>  arch/arm/mach-at91/sama7.c      | 3 +--
>  6 files changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
> index 4f8186211619..2ac564eb8bbb 100644
> --- a/arch/arm/mach-at91/at91rm9200.c
> +++ b/arch/arm/mach-at91/at91rm9200.c
> @@ -17,8 +17,6 @@
>  static void __init at91rm9200_dt_device_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -
> -	at91rm9200_pm_init();
>  }
>  
>  static const char *const at91rm9200_dt_board_compat[] __initconst = {
> @@ -27,6 +25,7 @@ static const char *const at91rm9200_dt_board_compat[] __initconst = {
>  };
>  
>  DT_MACHINE_START(at91rm9200_dt, "Atmel AT91RM9200")
> +	.init_late	= at91rm9200_pm_init,
>  	.init_machine	= at91rm9200_dt_device_init,
>  	.dt_compat	= at91rm9200_dt_board_compat,
>  MACHINE_END
> diff --git a/arch/arm/mach-at91/at91sam9.c b/arch/arm/mach-at91/at91sam9.c
> index 7e572189a5eb..cf07cba4ee5d 100644
> --- a/arch/arm/mach-at91/at91sam9.c
> +++ b/arch/arm/mach-at91/at91sam9.c
> @@ -17,8 +17,6 @@
>  static void __init at91sam9_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -
> -	at91sam9_pm_init();
>  }
>  
>  static const char *const at91_dt_board_compat[] __initconst = {
> @@ -28,6 +26,7 @@ static const char *const at91_dt_board_compat[] __initconst = {
>  
>  DT_MACHINE_START(at91sam_dt, "Atmel AT91SAM9")
>  	/* Maintainer: Atmel */
> +	.init_late	= at91sam9_pm_init,
>  	.init_machine	= at91sam9_init,
>  	.dt_compat	= at91_dt_board_compat,
>  MACHINE_END
> diff --git a/arch/arm/mach-at91/sam9x60.c b/arch/arm/mach-at91/sam9x60.c
> index d8c739d25458..a31beaaeffcd 100644
> --- a/arch/arm/mach-at91/sam9x60.c
> +++ b/arch/arm/mach-at91/sam9x60.c
> @@ -18,8 +18,6 @@
>  static void __init sam9x60_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -
> -	sam9x60_pm_init();
>  }
>  
>  static const char *const sam9x60_dt_board_compat[] __initconst = {
> @@ -29,6 +27,7 @@ static const char *const sam9x60_dt_board_compat[] __initconst = {
>  
>  DT_MACHINE_START(sam9x60_dt, "Microchip SAM9X60")
>  	/* Maintainer: Microchip */
> +	.init_late	= sam9x60_pm_init,
>  	.init_machine	= sam9x60_init,
>  	.dt_compat	= sam9x60_dt_board_compat,
>  MACHINE_END
> diff --git a/arch/arm/mach-at91/sam9x7.c b/arch/arm/mach-at91/sam9x7.c
> index e1ff30b5b09b..0c73f7fefd4f 100644
> --- a/arch/arm/mach-at91/sam9x7.c
> +++ b/arch/arm/mach-at91/sam9x7.c
> @@ -17,8 +17,6 @@
>  static void __init sam9x7_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -
> -	sam9x7_pm_init();
>  }
>  
>  static const char * const sam9x7_dt_board_compat[] __initconst = {
> @@ -28,6 +26,7 @@ static const char * const sam9x7_dt_board_compat[] __initconst = {
>  
>  DT_MACHINE_START(sam9x7_dt, "Microchip SAM9X7")
>  	/* Maintainer: Microchip */
> +	.init_late	= sam9x7_pm_init,
>  	.init_machine	= sam9x7_init,
>  	.dt_compat	= sam9x7_dt_board_compat,
>  MACHINE_END
> diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91/sama5.c
> index bf2b5c6a18c6..efae697ce29c 100644
> --- a/arch/arm/mach-at91/sama5.c
> +++ b/arch/arm/mach-at91/sama5.c
> @@ -33,7 +33,6 @@ static void __init sama5_secure_cache_init(void)
>  static void __init sama5_dt_device_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -	sama5_pm_init();
>  }
>  
>  static const char *const sama5_dt_board_compat[] __initconst = {
> @@ -43,6 +42,7 @@ static const char *const sama5_dt_board_compat[] __initconst = {
>  
>  DT_MACHINE_START(sama5_dt, "Atmel SAMA5")
>  	/* Maintainer: Atmel */
> +	.init_late	= sama5_pm_init,
>  	.init_machine	= sama5_dt_device_init,
>  	.dt_compat	= sama5_dt_board_compat,
>  MACHINE_END
> diff --git a/arch/arm/mach-at91/sama7.c b/arch/arm/mach-at91/sama7.c
> index bd43733ede18..3e28727f2a8e 100644
> --- a/arch/arm/mach-at91/sama7.c
> +++ b/arch/arm/mach-at91/sama7.c
> @@ -17,8 +17,6 @@
>  static void __init sama7_dt_device_init(void)
>  {
>  	of_platform_default_populate(NULL, NULL, NULL);
> -	sama7_pm_init();
> -}

} was dropped as well.

Thank you,
Claudiu