linux-kernel - Re: [PATCH] fix MIC buffer sizing in selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2735328.1763716365@warthog.procyon.org.uk>
Date: Fri, 21 Nov 2025 09:12:45 +0000
From: David Howells <dhowells@...hat.com>
To: Joep Duin <joepduin12@...il.com>,
    Herbert Xu <herbert@...dor.apana.org.au>
Cc: dhowells@...hat.com, davem@...emloft.net,
    linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix MIC buffer sizing in selftest

Herbert Xu <herbert@...dor.apana.org.au> wrote:

> >        /* Generate a MIC generation request. */
> > -       sg_init_one(sg, buf, 1024);
> > +       sg_init_one(sg, buf, message_len);
> > 
> > -       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> > -                                 krb5->cksum_len, plain.len);
> > +       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> > +                   krb5->cksum_len, plain.len);

The buffer doesn't need to fit exactly, it just needs to be big enough to hold
the output produced, but it can be bigger.

David