linux-kernel - Re: [PATCH] fix MIC buffer sizing in selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR_spUmU7FswxA2Q@gondor.apana.org.au>
Date: Fri, 21 Nov 2025 12:37:57 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Joep Duin <joepduin12@...il.com>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	165405982+joepduin@...rs.noreply.github.com, joepduin12@...il.com,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] fix MIC buffer sizing in selftest

Joep Duin <joepduin12@...il.com> wrote:
> From: Joep Duin <165405982+joepduin@...rs.noreply.github.com>
> 
> Signed-off-by: Joep Duin <joepduin12@...il.com>
> ---
> crypto/krb5/selftest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/krb5/selftest.c b/crypto/krb5/selftest.c
> index 4519c572d37e..82b2b6a3607d 100644
> --- a/crypto/krb5/selftest.c
> +++ b/crypto/krb5/selftest.c
> @@ -427,10 +427,10 @@ static int krb5_test_one_mic(const struct krb5_mic_test *test, void *buf)
>        memcpy(buf + offset, plain.data, plain.len);
> 
>        /* Generate a MIC generation request. */
> -       sg_init_one(sg, buf, 1024);
> +       sg_init_one(sg, buf, message_len);
> 
> -       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> -                                 krb5->cksum_len, plain.len);
> +       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> +                   krb5->cksum_len, plain.len);

I have no idea what you're trying to fix here.  Please explain
the problem.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt