linux-kernel - Re: [PATCH v2 07/13] dmaengine: lgm: use sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSGCJQc152Y9V10E@vaman>
Date: Sat, 22 Nov 2025 14:58:05 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Stefan Wahren <wahrenst@....net>,
	Thomas Andreatta <thomasandreatta2000@...il.com>,
	Caleb Sander Mateos <csander@...estorage.com>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	Olivier Dautricourt <olivierdautricourt@...il.com>,
	Stefan Roese <sr@...x.de>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Lizhi Hou <lizhi.hou@....com>, Brian Xu <brian.xu@....com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@....com>,
	Michal Simek <michal.simek@....com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 07/13] dmaengine: lgm: use sg_nents_for_dma() helper

On 10-11-25, 11:23, Andy Shevchenko wrote:
> Instead of open coded variant let's use recently introduced helper.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/lgm/lgm-dma.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/dma/lgm/lgm-dma.c b/drivers/dma/lgm/lgm-dma.c
> index 8173c3f1075a..7d4d3dde6d88 100644
> --- a/drivers/dma/lgm/lgm-dma.c
> +++ b/drivers/dma/lgm/lgm-dma.c
> @@ -1164,8 +1164,8 @@ ldma_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>  	struct dw2_desc *hw_ds;
>  	struct dw2_desc_sw *ds;
>  	struct scatterlist *sg;
> -	int num = sglen, i;
>  	dma_addr_t addr;
> +	int num, i;
>  
>  	if (!sgl)
>  		return NULL;
> @@ -1173,12 +1173,7 @@ ldma_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>  	if (d->ver > DMA_VER22)
>  		return ldma_chan_desc_cfg(chan, sgl->dma_address, sglen);
>  
> -	for_each_sg(sgl, sg, sglen, i) {
> -		avail = sg_dma_len(sg);
> -		if (avail > DMA_MAX_SIZE)
> -			num += DIV_ROUND_UP(avail, DMA_MAX_SIZE) - 1;
> -	}
> -
> +	num = sg_nents_for_dma(sgl, sg_len, DMA_MAX_SIZE);

drivers/dma/lgm/lgm-dma.c:1176:37: error: ‘sg_len’ undeclared (first use in this function); did you mean ‘sglen’?
         num = sg_nents_for_dma(sgl, sg_len, DMA_MAX_SIZE);

I am getting the build failure, as well as few unused warning with this,
pls fix

-- 
~Vinod