linux-kernel - Re: [PATCH v2 07/13] dmaengine: lgm: use sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSRLIY4KmhAxePq1@smile.fi.intel.com>
Date: Mon, 24 Nov 2025 14:10:09 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vinod Koul <vkoul@...nel.org>
Cc: Stefan Wahren <wahrenst@....net>,
	Thomas Andreatta <thomasandreatta2000@...il.com>,
	Caleb Sander Mateos <csander@...estorage.com>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	Olivier Dautricourt <olivierdautricourt@...il.com>,
	Stefan Roese <sr@...x.de>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Lizhi Hou <lizhi.hou@....com>, Brian Xu <brian.xu@....com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@....com>,
	Michal Simek <michal.simek@....com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 07/13] dmaengine: lgm: use sg_nents_for_dma() helper

On Sat, Nov 22, 2025 at 02:58:05PM +0530, Vinod Koul wrote:
> On 10-11-25, 11:23, Andy Shevchenko wrote:
> > Instead of open coded variant let's use recently introduced helper.

...

> > +	num = sg_nents_for_dma(sgl, sg_len, DMA_MAX_SIZE);
> 
> drivers/dma/lgm/lgm-dma.c:1176:37: error: ‘sg_len’ undeclared (first use in this function); did you mean ‘sglen’?
>          num = sg_nents_for_dma(sgl, sg_len, DMA_MAX_SIZE);
> 
> I am getting the build failure, as well as few unused warning with this,
> pls fix

Indeed, sorry for that, in v4 should be fixed.
Thanks!

-- 
With Best Regards,
Andy Shevchenko