linux-kernel - Re: [PATCH V3 13/14] LoongArch: Adjust default config files for 32BIT/64BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4Vemxni8PrMCeubUwWcOFAV-j6AFJg4oPdxs-VNBiUGw@mail.gmail.com>
Date: Sat, 22 Nov 2025 19:58:24 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Thomas Weißschuh <thomas@...ch.de>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, Arnd Bergmann <arnd@...db.de>, loongarch@...ts.linux.dev, 
	linux-arch@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>, 
	Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>, 
	Jiaxun Yang <jiaxun.yang@...goat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 13/14] LoongArch: Adjust default config files for 32BIT/64BIT

Hi, Thomas,

On Sat, Nov 22, 2025 at 5:45 PM Thomas Weißschuh <thomas@...ch.de> wrote:
>
> On 2025-11-22 12:36:33+0800, Huacai Chen wrote:
> > Add loongson32_defconfig (for 32BIT) and rename loongson3_defconfig to
> > loongson64_defconfig (for 64BIT).
> >
> > Also adjust graphics drivers, such as FB_EFI is replaced with EFIDRM.
> >
> > Reviewed-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > ---
> >  arch/loongarch/Makefile                       |    7 +-
> >  arch/loongarch/configs/loongson32_defconfig   | 1104 +++++++++++++++++
> >  ...ongson3_defconfig => loongson64_defconfig} |    6 +-
> >  3 files changed, 1113 insertions(+), 4 deletions(-)
> >  create mode 100644 arch/loongarch/configs/loongson32_defconfig
> >  rename arch/loongarch/configs/{loongson3_defconfig => loongson64_defconfig} (99%)
> >
> > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > index 96ca1a688984..cf9373786969 100644
> > --- a/arch/loongarch/Makefile
> > +++ b/arch/loongarch/Makefile
> > @@ -5,7 +5,12 @@
> >
> >  boot := arch/loongarch/boot
> >
> > -KBUILD_DEFCONFIG := loongson3_defconfig
> > +ifdef CONFIG_32BIT
>
> Testing for CONFIG options here doesn't make sense, as the config is not yet
> created. Either test for $(ARCH) or uname or just use one unconditionally.
> Also as mentioned before, snippets can reduce the duplication.
Thank you for your clarification. But $(ARCH) also doesn't make sense
because it is always "loongarch".

'uname' is an option but I think it doesn't work for cross compile?


Huacai

>
> > +KBUILD_DEFCONFIG := loongson32_defconfig
> > +else
> > +KBUILD_DEFCONFIG := loongson64_defconfig
> > +endif
> > +
> >  KBUILD_DTBS      := dtbs
> >
> >  image-name-y                 := vmlinux
>
> (...)