linux-kernel - RE: [PATCH v3 02/13] serial: rsci: Drop rsci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346856B35E21B24201E95D986D2A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sat, 22 Nov 2025 12:49:18 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
	<jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, magnus.damm
	<magnus.damm@...il.com>, wsa+renesas <wsa+renesas@...g-engineering.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v3 02/13] serial: rsci: Drop rsci_clear_CFC()

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 21 November 2025 14:53
> Subject: Re: [PATCH v3 02/13] serial: rsci: Drop rsci_clear_CFC()
> 
> Hi Biju,
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > Drop rsci_clear_CFC() by reusing rsci_clear_SCxSR() as the contents of
> > both functions are the same.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/drivers/tty/serial/rsci.c
> > +++ b/drivers/tty/serial/rsci.c
> > @@ -199,11 +199,6 @@ static unsigned int rsci_get_mctrl(struct uart_port *port)
> >         return 0;
> >  }
> >
> > -static void rsci_clear_CFC(struct uart_port *port, unsigned int mask)
> > -{
> > -       rsci_serial_out(port, CFCLR, mask);
> > -}
> > -
> 
> This function is indeed identical to rsci_clear_SCxSR(), so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> However, while the sci_port_ops method is indeed called .clear_SCxSR(), I think it makes more sense to
> drop rsci_clear_SCxSR() instead, as this function touches the CFC register...

OK, will change this in next version.

Cheers,
Biju