linux-kernel - Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca517274-9238-4f76-98c5-2fd31276d64f@web.de>
Date: Sat, 22 Nov 2025 20:58:12 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Simon Horman <horms@...nel.org>,
 Stephen Hemminger <stephen@...workplumber.org>,
 Vladimir Oltean <olteanv@...il.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse_of

…
> returned structure, which should be balanced with a corresponding
> put_device() when the reference is no longer needed.
…

* Would a corresponding imperative wording become helpful for an improved change description?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94

* How do you think about to omit an extra check for the variable “err”
  in the affected if branch because it can always be returned here?

* Would it be helpful to append parentheses to the function name in the summary phrase?

Regards,
Markus