linux-kernel - Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025112332-moonscape-varmint-86b1@gregkh>
Date: Sun, 23 Nov 2025 07:22:38 +0100
From: Greg KH <greg@...ah.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: make24@...as.ac.cn, netdev@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>, Simon Horman <horms@...nel.org>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Vladimir Oltean <olteanv@...il.com>, stable@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse_of

On Sat, Nov 22, 2025 at 08:58:12PM +0100, Markus Elfring wrote:
> …
> > returned structure, which should be balanced with a corresponding
> > put_device() when the reference is no longer needed.
> …
> 
> * Would a corresponding imperative wording become helpful for an improved change description?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94
> 
> * How do you think about to omit an extra check for the variable “err”
>   in the affected if branch because it can always be returned here?
> 
> * Would it be helpful to append parentheses to the function name in the summary phrase?
> 
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot