linux-kernel - Re: [PATCH 2/6] dt-bindings: mfd: maxim,max77759: add charger child node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <699d4476-aaaa-4cec-9e2c-240348950e4c@kernel.org>
Date: Sun, 23 Nov 2025 10:30:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: amitsd@...gle.com, Sebastian Reichel <sre@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, André Draszik
 <andre.draszik@...aro.org>, Lee Jones <lee@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Badhri Jagan Sridharan <badhri@...gle.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Alim Akhtar <alim.akhtar@...sung.com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 RD Babiera <rdbabiera@...gle.com>, Kyle Tso <kyletso@...gle.com>
Subject: Re: [PATCH 2/6] dt-bindings: mfd: maxim,max77759: add charger child
 node

On 23/11/2025 09:35, Amit Sunil Dhamne via B4 Relay wrote:
> From: Amit Sunil Dhamne <amitsd@...gle.com>
> 
> The Maxim MAX77759 MFD includes a charger function, hence add its
> binding as a property. Also, update the example to include charger.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@...gle.com>
> ---
>  Documentation/devicetree/bindings/mfd/maxim,max77759.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> index 525de9ab3c2b..29132f73f2c8 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> @@ -37,6 +37,9 @@ properties:
>    nvmem-0:
>      $ref: /schemas/nvmem/maxim,max77759-nvmem.yaml
>  
> +  charger:
> +    $ref: /schemas/power/supply/maxim,max77759-charger.yaml

You need to explain dependencies/merging in the cover letter. This patch
now cannot be merged alone through MFD.

Or just decouple the dependency and list here only compatible, assuming
this child node even stays.

> +
>  required:
>    - compatible
>    - interrupts
> @@ -95,5 +98,14 @@ examples:
>                      };
>                  };
>              };
> +
> +            charger {
> +                compatible = "maxim,max77759-charger";
> +                power-supplies = <&maxtcpc>;

Feels like you miss here battery.


Best regards,
Krzysztof