linux-kernel - Re: [PATCH v5 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e50c694-af6b-40cc-b1dc-4dd4ecf85a8d@kernel.org>
Date: Sun, 23 Nov 2025 10:42:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rogerio Pimentel <rpimentel.silva@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, shawnguo@...nel.org,
 s.hauer@...gutronix.de
Cc: kernel@...gutronix.de, festevam@...il.com,
 alexander.stein@...tq-group.com, dario.binacchi@...rulasolutions.com,
 marex@...x.de, Markus.Niebel@...group.com, y.moog@...tec.de,
 joao.goncalves@...adex.com, frieder.schrempf@...tron.de,
 josua@...id-run.com, francesco.dolcini@...adex.com, primoz.fiser@...ik.com,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Xiaofeng Wei <xiaofeng.wei@....com>, Joseph Guo <qijian.guo@....com>,
 Steven Yang <steven.yang@....com>, Lei Xu <lei.xu@....com>
Subject: Re: [PATCH v5 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

On 23/11/2025 01:36, Rogerio Pimentel wrote:
> The FRDM-i.MX8MP is an NXP development platform based on the i.MX8M Plus
> SoC, featuring a quad Cortex-A53, Cortex-M7 co-processor, 4GB LPDDR4,
> 32GB eMMC, Wi-Fi 6/Bluetooth 5.4/802.15.4 tri-radio, Ethernet, HDMI/MIPI
> display interfaces, camera connectors, and standard expansion headers.
> 
> Based on the device tree found in the NXP repository at github
> https://github.com/nxp-imx-support/meta-imx-frdm and on imx8mp-evk
> board kernel mainline device tree.
> 
> This is a basic device tree supporting:
> 
>  - Quad Cortex-A53
>  - 4GB LPDDR4 DRAM
>  - PCA9450C PMIC with regulators
>  - Two NXP PCAL6416 GPIO expanders
>  - RGB LEDs via GPIO expander
>  - I2C1, I2C2, I2C3 controllers
>  - UART2 (console) and UART3 (with RTS/CTS)
>  - USDHC3 (8-bit eMMC)
>  - SNVS power key (onboard power button)
> 
> Author: Xiaofeng Wei <xiaofeng.wei@....com>

There is no such tag. Use git commit --amend --reset-author to set the
author.

> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@....com>
> 
> Co-developed-by: Joseph Guo <qijian.guo@....com>
> Signed-off-by: Joseph Guo <qijian.guo@....com>
> 

There is never blank line between tags.

> Co-developed-by: Steven Yang <steven.yang@....com>
> Signed-off-by: Steven Yang <steven.yang@....com>
> 
> Co-developed-by: Lei Xu <lei.xu@....com>
> Signed-off-by: Lei Xu <lei.xu@....com>
> 
> Co-developed-by: Rogerio Pimentel <rpimentel.silva@...il.com>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@...il.com>
> ---
> 
> Changes in v5:
> 
>  - Replace underscores (_) in node names with dashes (-)
>  - Added missing Co-developed-by and Signed-off-by tags from all contributors

I assume you actually saw these SoBs in the code you took as your base?
Remember, do not add SoBs which were never present in the original work
(if company asks you, you can politely reply that they need to read what
SoB means)

That's anyway weirdly a lot of co-developed tags, are you sure they
wrote the code you took as the base here?

Best regards,
Krzysztof