linux-kernel - Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251124-encouraging-snobbish-nuthatch-230bcb@lemur>
Date: Mon, 24 Nov 2025 11:28:28 -0500
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: ally heev <allyheev@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Miri Korenblit <miriam.rachel.korenblit@...el.com>, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused
 variable in d3.c

On Mon, Nov 24, 2025 at 09:28:39PM +0530, ally heev wrote:
> > > > Best regards,
> > > > -----BEGIN PGP SIGNATURE-----
> > > > 
> > > > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > > > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > > > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > > > =A6F+
> > > > -----END PGP SIGNATURE-----
> > > 
> > > You should switch to patatt instead, not signing emails. We don't use
> > > that, I think at all, unlike patatt which is being actively checked by
> > > toolkit (b4).
> > 
> > It's even more curious. The patch was sent with b4, but I'm pretty sure we
> > wouldn't have put the PGP signature in like that, so I'm curious how that even
> > happened.
> > 
> > Ally, can you shed some light on that?
> > 
> > -K
> 
> Yes, I use b4 for my patches. I work on other open source projects
> which use Github. So, my global git config commit autosign is set to
> `true`, hence you have seen PGP signatures. 

Interesting! I've not seen this cause PGP signatures to be added to "git show"
output before. I've tried to replicate it locally, but even if I have a signed
git commit, I can't make the "gpgsig" header to show up in the output of "git
show --format=email" (which is what b4 uses). Do you have some local git
configuration changes that make "gpgsig" fields show up in the output of "git
show"?

-K