linux-kernel - Re: [PATCH] staging: greybus: audio_manager: make envp[] static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025112407-gratify-demanding-c817@gregkh>
Date: Mon, 24 Nov 2025 17:37:25 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Sameeksha Sankpal <sameekshasankpal@...il.com>
Cc: vaibhav.sr@...il.com, mgreer@...malcreek.com, johan@...nel.org,
	elder@...nel.org, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager: make envp[] static const

On Sat, Nov 22, 2025 at 02:08:13PM +0530, Sameeksha Sankpal wrote:
> The envp[] array contains string literals and is never modified.
> Declare it as 'static const char * const' to place it in read-only
> memory and avoid unnecessary stack usage.
> 
> This fixes a checkpatch warning:
> "char * array declaration might be better as static const"
> 
> Signed-off-by: Sameeksha Sankpal <sameekshasankpal@...il.com>
> ---
>  drivers/staging/greybus/audio_manager_module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 4a4dfb42f50f..1b83c05f2434 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -159,7 +159,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
>  	char ip_devices_string[64];
>  	char op_devices_string[64];
>  
> -	char *envp[] = {
> +	static const char * const envp[] = {
>  		name_string,
>  		vid_string,
>  		pid_string,
> -- 
> 2.43.0
> 
> 

Any specific reason why you did not build this patch before submitting
it?  Please always do so.

thanks,

greg k-h