linux-kernel - Re: [PATCH] staging: greybus: audio_manager: make envp[] static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511241614.lkKJF5B6-lkp@intel.com>
Date: Mon, 24 Nov 2025 17:11:14 +0800
From: kernel test robot <lkp@...el.com>
To: Sameeksha Sankpal <sameekshasankpal@...il.com>, vaibhav.sr@...il.com,
	mgreer@...malcreek.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, johan@...nel.org,
	elder@...nel.org, gregkh@...uxfoundation.org,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Sameeksha Sankpal <sameekshasankpal@...il.com>
Subject: Re: [PATCH] staging: greybus: audio_manager: make envp[] static const

Hi Sameeksha,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Sameeksha-Sankpal/staging-greybus-audio_manager-make-envp-static-const/20251122-163906
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20251122083814.49753-1-sameekshasankpal%40gmail.com
patch subject: [PATCH] staging: greybus: audio_manager: make envp[] static const
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20251124/202511241614.lkKJF5B6-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251124/202511241614.lkKJF5B6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511241614.lkKJF5B6-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/greybus/audio_manager_module.c:163:3: error: initializer element is not a compile-time constant
     163 |                 name_string,
         |                 ^~~~~~~~~~~
>> drivers/staging/greybus/audio_manager_module.c:181:46: error: passing 'const char *const[7]' to parameter of type 'char **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
     181 |         kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
         |                                                     ^~~~
   include/linux/kobject.h:216:10: note: passing argument to parameter 'envp' here
     216 |                         char *envp[]);
         |                               ^
   2 errors generated.


vim +163 drivers/staging/greybus/audio_manager_module.c

8db00736d365b7 Svetlin Ankov     2016-01-13  152  
8db00736d365b7 Svetlin Ankov     2016-01-13  153  static void send_add_uevent(struct gb_audio_manager_module *module)
8db00736d365b7 Svetlin Ankov     2016-01-13  154  {
8db00736d365b7 Svetlin Ankov     2016-01-13  155  	char name_string[128];
8db00736d365b7 Svetlin Ankov     2016-01-13  156  	char vid_string[64];
8db00736d365b7 Svetlin Ankov     2016-01-13  157  	char pid_string[64];
d0af1bd5f6f449 Pankaj Bharadiya  2016-10-16  158  	char intf_id_string[64];
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  159  	char ip_devices_string[64];
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  160  	char op_devices_string[64];
8db00736d365b7 Svetlin Ankov     2016-01-13  161  
c78cfcfa51fa58 Sameeksha Sankpal 2025-11-22  162  	static const char * const envp[] = {
8db00736d365b7 Svetlin Ankov     2016-01-13 @163  		name_string,
8db00736d365b7 Svetlin Ankov     2016-01-13  164  		vid_string,
8db00736d365b7 Svetlin Ankov     2016-01-13  165  		pid_string,
d0af1bd5f6f449 Pankaj Bharadiya  2016-10-16  166  		intf_id_string,
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  167  		ip_devices_string,
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  168  		op_devices_string,
8db00736d365b7 Svetlin Ankov     2016-01-13  169  		NULL
8db00736d365b7 Svetlin Ankov     2016-01-13  170  	};
8db00736d365b7 Svetlin Ankov     2016-01-13  171  
8db00736d365b7 Svetlin Ankov     2016-01-13  172  	snprintf(name_string, 128, "NAME=%s", module->desc.name);
8db00736d365b7 Svetlin Ankov     2016-01-13  173  	snprintf(vid_string, 64, "VID=%d", module->desc.vid);
8db00736d365b7 Svetlin Ankov     2016-01-13  174  	snprintf(pid_string, 64, "PID=%d", module->desc.pid);
d0af1bd5f6f449 Pankaj Bharadiya  2016-10-16  175  	snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id);
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  176  	snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  177  		 module->desc.ip_devices);
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  178  	snprintf(op_devices_string, 64, "O/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal   2016-03-30  179  		 module->desc.op_devices);
8db00736d365b7 Svetlin Ankov     2016-01-13  180  
8db00736d365b7 Svetlin Ankov     2016-01-13 @181  	kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
8db00736d365b7 Svetlin Ankov     2016-01-13  182  }
8db00736d365b7 Svetlin Ankov     2016-01-13  183  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki